search

brcontainer / prevent-duplicate-tabs

Simple add-on/extension for prevent duplicate tabs
MIT License
60 stars 7 forks source link

Compatibility with Sidebery Addon #11

Open HenryTheVacuum opened 3 years ago

HenryTheVacuum commented 3 years ago

Issues with switching panels and older tabs closing no matter what setting is chosen in this extensions options.

brcontainer commented 3 years ago

@jesse9212 this https://addons.mozilla.org/en-US/firefox/addon/sidebery/ ? it looks like the addon project died. I have no way to test, anyway try to enable "ONLY HTTP" option:

1

HenryTheVacuum commented 3 years ago

Tried every setting, no luck. I think it has to do with how Sidebery handles closing tabs (they offer many options which may be interfering).

https://github.com/mbnuqw/sidebery

The developer said they are working on a new version, not sure why it was removed from ff addons site, however. https://github.com/mbnuqw/sidebery/issues/331#issuecomment-747187148

brcontainer commented 3 years ago

@jesse9212 I will start analyzing and then come up with a way to solve this in an easy way for the user.

brcontainer commented 3 years ago

@jesse9212 I tried using:

I tried to drag the tabs inside the Sidebery, I tried to use the "Remove Panel" option to move the tabs to an existing panel, I tried to close the browser and restore the tabs that were in the Sidebery. Apparently, at no time did "prevent-tabs" cause conflict. If you can explain the step by step or even make a video and put it on a website like youtube (or similar) if it is a complicated process to explain. If you can explain exactly how this conflicting process did, I promise to correct it as soon as possible. Thanks.

HenryTheVacuum commented 3 years ago

https://i.imgur.com/XSVXZKS.gif See how it closes the older one and keeps the current tab open even when settings are set to not do so. The same thing happens wth the two settings on as well.

Try unloading the original tab of the duplicate as well.

brcontainer commented 3 years ago

@jesse9212 this seems to be a problem independent of the "sidebar", I am analyzing and will try to correct it today. Thanks!

HenryTheVacuum commented 3 years ago

Glad we caught it, I just ask you test the sidebar where the older tab is in another "panel" and that when closing the new duplicate tab it switches to the panel and older tab.

There was another issue where it did switch to the correct panel, but did not activate the old tab.

Thanks so much.

brcontainer commented 3 years ago

@jesse9212 I will try in every possible way, thanks for reporting.

HenryTheVacuum commented 3 years ago

Seems to be working now except it only closes the new duplicate tab and switches the panel to activate the older tab when that older tab is in the "next panel" of sidebery. If it's in the "previous panel" then it closes the oldest tab which is wrong.

brcontainer commented 3 years ago

Seems to be working now except it only closes the new duplicate tab and switches the panel to activate the older tab when that older tab is in the "next panel" of sidebery. If it's in the "previous panel" then it closes the oldest tab which is wrong.

I think I understand, I'll try to reproduce the error.

brcontainer commented 1 year ago

@HenryTheVacuum In version 0.7.9 (or newer) the chrome.tabs.Tab.pendingUrl was added, possibly this would solve the issue with any "pending" tab, could you check if it solved the compatibility? I appreciate it!

HenryTheVacuum commented 1 year ago

Scenario I tested: 2 windows open with multiple tabs.

The issue is fixed if I turn off "preserve active tab". If "preserve active tab" is turned on, the older tab will be closed (even if keep older tab is turned on). Maybe I'm confused about the the "p.a.t." setting objective.

Another issue still persists. If tab exists in window 2 but is not the active tab, creating a new duplicate tab in window 1 will close correctly, but then the old tab in window 2 will not activate.