brdevstreamers / brdevstreamers-ui

https://brstreamers.dev

Apache License 2.0

60 stars 20 forks source link

Feature/raid button #45

Closed joaom00 closed 2 years ago

joaom00 commented 2 years ago

This PR adds raid button to copy raid command to clipboard.

Demo

https://user-images.githubusercontent.com/48808846/158694797-e927c571-cca5-40ec-94a7-7b0b6fd3e4a6.mp4

Closes #24

NandoSangenetto commented 2 years ago

The button is too close to the text. Do you think it is possible to increase the space between them?

NandoSangenetto commented 2 years ago

Adding @brunobandev as a reviewer to check this design change.

Btw, it is a nice feature. That is going to be useful.

Ps: Make sure to fix the test :D

joaom00 commented 2 years ago

The test is passing on my machine. I don't know what could have happened to have failed.

joaom00 commented 2 years ago

Thanks! @brunobandev

NandoSangenetto commented 2 years ago

The test is passing on my machine. I don't know what could have happened to have failed.

I'm going to try it here tomorrow.

NandoSangenetto commented 2 years ago

@joaom00 It is a flaky test. It will work most of the time testing using the Cypress' graphic interface (yarn open) but it will always fail when using the CLI (yarn cy:run).

I could find some workarounds, take a look:

NandoSangenetto commented 2 years ago

Also, I was thinking here.

The raid button is not something that most users will use. It is going to be used by streamers. It would be nice if the user could set the website as "streamer mode." It could be a toggle button.

joaom00 commented 2 years ago

@nandosangenetto All tests are passing!!

joaom00 commented 2 years ago

Also, I was thinking here.

The raid button is not something that most users will use. It is going to be used by streamers. It would be nice if the user could set the website as "streamer mode." It could be a toggle button.

Would it make sense to do this just for the raid button? I think it would make sense if we had more features for streamers. This would fit in with what @brunobandev suggested #23

NandoSangenetto commented 2 years ago

Also, I was thinking here. The raid button is not something that most users will use. It is going to be used by streamers. It would be nice if the user could set the website as "streamer mode." It could be a toggle button.

Would it make sense to do this just for the raid button? I think it would make sense if we had more features for streamers. This would fit in with what @brunobandev suggested #23

Yeah, we can discuss that later.