search

breadadams / scroller-motion

🛹 Elegant motion scrolling for React
https://scroller-motion.js.org
MIT License
67 stars 5 forks source link

Refactored useSpringScroll to remove unnecessary uses of useMemo #5

Closed rijk closed 3 years ago

rijk commented 4 years ago

This is not super important, but while trying to fix something else (I'll open up an issue for it later) I came across this piece of code which I thought would be a little more legible like this.

breadadams commented 3 years ago

Thanks for this @rijk, and sorry for the delay in getting back to you on the issues I saw you opened - been swamped with work...

I'll be looking at it all next week 👍

gabrielperales commented 3 years ago

@breadadams looks good to me... there aren't complex calculations to need useMemo

breadadams commented 3 years ago

Btw @rijk if you want to provide an email/website we can get you in the package.json contributors list 🙂, or feel free to open a PR with it yourself.