breadwallet / breadwallet-android

The Android version of the Bread bitcoin wallet.
MIT License
389 stars 424 forks source link

walletkit-java not found on bintray #199

Closed dabitdev closed 3 years ago

dabitdev commented 3 years ago

Could not GET 'https://dl.bintray.com/brd/walletkit-java/com/breadwallet/core/corecrypto-android/6.2.2/corecrypto-android-6.2.2.aar'. Received status code 403 from server: Forbidden Disable Gradle 'offline mode' and sync project

dabitdev commented 3 years ago

Hi @DrewCarlson, this is blocking me. Could you upload the artifacts to another maven? If you could share the artifacts I could add them locally too.

DrewCarlson commented 3 years ago

When the source code for 4.10.0 is published, you'll find all bintray repositories replaced. The two missing dependencies redacted and walletkit are included as git submodules+composite gradle builds.

If you'd like to make the artifacts permanently available, publishing to a maven repository (like Artifactory) is documented here: https://github.com/blockset-corp/walletkit/tree/core-6.2.2/WalletKitJava#publishing

Though to unblock yourself, checking out the core tag, running ./gradlew publishToMavenLocal, and then adding the mavenLocal() repository is likely the quickest path forward.

dabitdev commented 3 years ago

Could I use ZacSweers/redacted-compiler-plugin (he has artifact at repo.maven.apache.org/maven2) or do I have to use your fork?

DrewCarlson commented 3 years ago

There is nothing special about the previously used Redacted artifacts, they were just built in-house. You can apply this patch https://github.com/breadwallet/breadwallet-android/issues/197#issuecomment-856952294

DrewCarlson commented 3 years ago

Resolved with the latest release, see https://github.com/breadwallet/brd-mobile