breadwallet / breadwallet-android

The Android version of the Bread bitcoin wallet.
MIT License
388 stars 427 forks source link

BCH BIP-70 Support #60

Closed zquestz closed 1 day ago

zquestz commented 6 years ago

Please add BIP-70 support for BCH. Many users need this to pay at BitPay supported merchants!

zquestz commented 6 years ago

Any time frame? I heard from a little bird this was nearly complete. =)

Gutyn commented 6 years ago

@zquestz BIP-70 is supported for both BTC and BCH in BRD unless you encounter a bug.

zquestz commented 6 years ago

This is incorrect. BIP-70 fails to work on my Android build. It scans it, then closes the send window immediately with no funds sent. I can confirm this is happening to other users as well.

zquestz commented 6 years ago

Also notice this page -> https://support.bitpay.com/hc/en-us/articles/115005701523-Which-wallets-work-for-a-BitPay-payment-Which-wallets-are-compatible-

Shows it only works for BTC, which it does. BCH is not working currently.

zquestz commented 6 years ago

Just tested again. The app fails, then crashes on the second attempt. Trying to donate to the EFF, and it definitely does not work with BRD. Please re-open the ticket.

Gutyn commented 6 years ago

Ok thanks for pointing the bug out, we'll investigate.

zquestz commented 6 years ago

Thank you for the quick reply. Really appreciate it!

zquestz commented 6 years ago

Release from today still does not work. Just a heads up.

imaginaryusername commented 6 years ago

Will like to see this fixed and usable too.

zander commented 6 years ago

I've been waiting for this support for some time. Just found this issue. Please add my vote to get this in.

derrickhorton commented 4 years ago

Same issue. BTC and BCH failing to send correctly with BRD wallet and Bip70 requests or even JSON style payment requests. It can read them but then somehow sends incorrectly. Something is messed up.