breadwallet / breadwallet-ios

The iOS version of the Bread bitcoin wallet.
http://breadapp.com
MIT License
640 stars 148 forks source link

recovery passwords in korean can't entered properly in recovery mode #93

Open HaesungSeo opened 5 years ago

HaesungSeo commented 5 years ago

the recovery function has three problems if the phone is configured to use Korean language.

1) the words in resource file (breadwallet\Resources\BIP39Words\ko.lproj\BIP39Words.plist) are not correct in grammatically. For example the word at line 114 is "ㄱㅖㅎㅚㄱ" (means plan in english), but we do not spell it such a way. we write the word as "계획".

2) let assume that the app choose to use "ㄱㅖㅎㅚㄱ" as one of twenty recovery words, surprisingly it display the words correctly as "계획". but the word "계획" is not listed any of source files. Any way it is a matter of display it may be not a big problem.

3) after that, in recovery mode, I can't enter the recovery word "ㄱㅖㅎㅚㄱ". the app can't read it as "ㄱㅖㅎㅚㄱ" nor "계획". it just read as "ㄱㅖㅎㅗㅣㄱ" and the recovery failed.

there're many such case exists, below is some examples, each line consists of three information. word in source file, at line number in .plist file, correct spelling "ㄱㅖㅎㅚㄱ", 1114, "계획" "ㄱㅚㄹㅗㅇㅜㅁ", 174, "괴로움" "ㄱㅚㅇㅈㅏㅇㅎㅣ, 175, "굉장히" "ㄱㅛㄱㅘㅅㅓ", 176, "교과서" "ㄱㅛㅎㅘㄴ", 185, "교환"

WSchnee commented 5 years ago

Same for Japanese kana. It’s possible to fill the fields out by copy pasting each word, but the app complains some of the fields are wrong.