breadweb / extralife-helper

The Extra Life Helper is a web app that can be used by Extra Life participants and teams to display their fundraising progress. Works in OBS and any modern browser. Features donation alerts, an event countdown timer, a timer for hours played, and multiple themes and display options.
https://breadweb.net/extralife-helper/
MIT License
27 stars 17 forks source link

Getting "$NaN" for goal #7

Closed japtar10101 closed 4 years ago

japtar10101 commented 4 years ago

Currently, the goal under our Extra Life Helper badge displays "$NaN" as the dollars raised for the team: https://tvgs.z13.web.core.windows.net/trailers/extra-life/ExtraLifeHelper/ExtraLifeHelper.html

chrome 2019-10-31 (22168)

The team is for Tech Valley Game Space. We're not sure why we get these results. The configuration is as follows:

// Extra Life Helper
// ============================================================================================
// For use details and use instructions, visit https://github.com/breadweb/extralife-helper
// For support or feature requests, visit http://bit.ly/helper-forum/
// 
participantId = "";    // Set this to blank to run in team mode.
teamId = "49460";      // Set this to blank to run in participant mode.
startDate = "11-02-2019";      // Set to your local Extra Life start date.
startTime = "12:00:00";// Set to your local Extra Life start time.
helperTheme = "white1";// Color theme: white1, gray1, blue1, or blue2.
helperBorder = "rounded";      // Border type: rounded, square, or none.
helperWidth = 250;     // Width of the Helper, in pixels.
showDonationAlerts = false;     // Set to false to suppress donation alerts.
showGoal = true;       // Set to false to only show amount raised on the
//     // main screen and not also your goal.
showYearMode = false;  // An alternate display to support fundraising all
//     // year. The count down/up timer is hidden.
donationSounds = "";   // Set this to your custom set of sounds, separated
//     // by commas. Or set to "" to play no sounds.
donationMessageVoice = "";     // Set to US-male, US-female, UK-male, UK-female,
//     // FR-male, FR-female, ES-male, ES-female or set
//     // to "" to not read messages with text-to-speech.  
testDonationSeconds = 0;       // Number of seconds to show a test donation after
//     // the Helper loads. Set to 0 to disable.
volume = 0;    // The volume for all sound effects and text-to-speech.
lang = "en-us";// Language to use for all text displayed in the
//     // Helper. Supported options are en-us for 
//     // English (United States), fr-ca for French (Canada),
//     // or es-419 for Spanish (Latin America)
// ============================================================================================
breadweb commented 4 years ago

Hmmm, I am not sure why the incorrect total is showing for only your team. I will do my best to look into it today but may not be able to since Extra Life is tomorrow. :O

breadweb commented 4 years ago

Hmmm, this appears to be happening for all teams...

timmixell commented 4 years ago

@breadweb PR is in to address this

timmixell commented 4 years ago

https://github.com/DonorDrive/PublicAPI/issues/26 for the DonorDrive API update

breadweb commented 4 years ago

@timmixell Thanks! I'll get this merged and deployed right now.

breadweb commented 4 years ago

This is fixed in the remote version (http://breadweb.net/extralife-helper.html) and the download version (https://github.com/breadweb/extralife-helper/releases/tag/3.2)

Thank you @japtar10101 for the report and thank you @timmixell for the quick fix!