search

breagen / MachSuite

Benchmarks for Accelerator Design and Customized Architectures
http://www.eecs.harvard.edu/~reagen/papers/machsuite.pdf
Other
114 stars 47 forks source link

Move nw initilization code into generate.c #3

Closed ysshao closed 9 years ago

ysshao commented 9 years ago

Also updated the input.data file.

The first two loops in nw are basically constant initializations. Since we already do all the initialization in the generate script, there is no reason to initialize them again in the benchmark file.

rdadolf commented 9 years ago

I'm tempted to leave this in. The scoring matrix is an intermediate data structure, not really an input. You wouldn't expect a user to supply it or initialize it. aes/aes requires similar initialization to its internal data structures. fft/strided requires its twiddle factors supplied, but fft/transpose computes and caches its own. Maybe we should standardize those.

ysshao commented 9 years ago

I see. That makes sense. Is the reason that we put these structures in the arguments because we don't want to have mallocs in the kernel codes?

And I agree, we should standardize this. I'll close this pull request then.