search

breagen / MachSuite

Benchmarks for Accelerator Design and Customized Architectures
http://www.eecs.harvard.edu/~reagen/papers/machsuite.pdf
Other
114 stars 47 forks source link

Fix for memory leaks #8

Closed kavros closed 8 years ago

kavros commented 8 years ago

I have noticed some memory leaks using valgrind.

Before fix

valgrind ./viterbi input.data check.data before

After fix

valgrind ./viterbi input.data check.data after

rdadolf commented 8 years ago

Yep. We never even made an attempt, since most of these were effectively hardware description functions.

These changes look reasonable, they shouldn't affect HLS, and the CI tests pass.

Has the 👍 from me. @breagen, feel free to merge and close this if you agree.

breagen commented 8 years ago

Looks good on my end. Thanks for contributing!

-Brandon

From: Bob Adolf notifications@github.com Sent: Sunday, October 2, 2016 3:48:57 PM To: breagen/MachSuite Subject: Re: [breagen/MachSuite] Fix for memory leaks (#8)

Yep. We never even made an attempt, since most of these were effectively hardware description functions.

These changes look reasonable, they shouldn't affect HLS, and the CI tests pass.

Has the ? from me. Brandon, feel free to merge and close this if you agree.

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_breagen_MachSuite_pull_8-23issuecomment-2D250991322&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=Exe6txyO2qYVyT4_L4kwc1PS58aGJjB9gwvS_q5uceI&m=LL_m-x-Gmb1YKybGaFXlK4yLyA1SyQUQESdEmqSpiKs&s=LtQ6TAeC-b5cxCchxYTP7jIHtU9BaVZyr7WLdlusssM&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ACQUle-2DnlHwOloYEnePBd-2DdquitG2eM-5Fks5qwAqpgaJpZM4KMFmZ&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=Exe6txyO2qYVyT4_L4kwc1PS58aGJjB9gwvS_q5uceI&m=LL_m-x-Gmb1YKybGaFXlK4yLyA1SyQUQESdEmqSpiKs&s=68Nyct-dy8JmIbezmElem_bRD1IVJtlSlJhMEmWihow&e=.