search

breaker27 / smarthomatic

smarthomatic
http://www.smarthomatic.org
34 stars 12 forks source link

rgb dimmer: save default color brightness #134

Closed wurststulle closed 9 years ago

wurststulle commented 9 years ago

this adds a new message type for saving the default color and brightness to eeprom. this PR contains all changes from https://github.com/breaker27/smarthomatic/pull/133

breaker27 commented 9 years ago

There is definitely no need for a new message type!

wurststulle commented 9 years ago

There is no functionality to save stuff to the eeprom. If you dont want to save it every time (with e.g. set) wie neues a new one. Am 26.02.2015 20:37 schrieb "breaker27" notifications@github.com:

Closed #134 https://github.com/breaker27/smarthomatic/pull/134.

— Reply to this email directly or view it on GitHub https://github.com/breaker27/smarthomatic/pull/134#event-242768802.

breaker27 commented 9 years ago

I think there would be two values: The one is the (normal) color (immediately shown when set), the other value would be the default color (immediately written to e2p, but not shown). I don't see a use case to set the default color without saving it to e2p.