breakerh / tiptap-image-resize

Simple React image resizer
https://breakerh.github.io/tiptap-image-resize/
MIT License
47 stars 11 forks source link

React 18 support #2

Open tcaputi opened 2 years ago

tcaputi commented 2 years ago

Describe the bug This extension doesn't seem to support React 18 (installation fails)

To Reproduce I am using npx create-t3-app which for the most part just creates a NextJS app with typescript.

Expected behavior The module can be installed without errors

Screenshots

 tom@tomc-mac  ~/Development/projects/t3-true-finals   main ±  npm i tiptap-imagresize
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: t3-true-finals@0.1.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"18.2.0" from the root project
npm ERR!   peer react@"^17.0.0 || ^18.0.0" from @tiptap/react@2.0.0-beta.199
npm ERR!   node_modules/@tiptap/react
npm ERR!     @tiptap/react@"^2.0.0-beta.199" from the root project
npm ERR!     peer @tiptap/react@"^2.0.0-beta.109" from tiptap-imagresize@1.0.2
npm ERR!     node_modules/tiptap-imagresize
npm ERR!       tiptap-imagresize@"*" from the root project
npm ERR!   1 more (react-dom)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.2" from tiptap-imagresize@1.0.2
npm ERR! node_modules/tiptap-imagresize
npm ERR!   tiptap-imagresize@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/tom/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
breakerh commented 2 years ago

Hello @tcaputi

Sorry for the late response I will release a new version this weekend which will solve your issue

tcaputi commented 2 years ago

Thank you very much. This seems like exactly what I was looking for

kyds3k commented 2 years ago

@breakerh hello! looking to see if this has been updated yet - thank you!

kasvith commented 1 year ago

@breakerh any update on fix

samyarkd commented 1 year ago

I will create a pr on this issue

amilich commented 1 year ago

Also seeing