breakfastquay / rubberband

Official mirror of Rubber Band Library, an audio time-stretching and pitch-shifting library.
http://breakfastquay.com/rubberband/
GNU General Public License v2.0
566 stars 91 forks source link

FreeBSD compatibility patch. #10

Closed yurivict closed 4 years ago

jbeich commented 6 years ago

<alloca.h> is also not available on DragonFly, NetBSD, OpenBSD. According to GNU libc manpage "<stdlib.h> includes <alloca.h>". My guess, <alloca.h> conditional is safe to drop.

rrrapha commented 5 years ago

<alloca.h> is also not available on DragonFly, NetBSD, OpenBSD. According to GNU libc manpage "<stdlib.h> includes <alloca.h>". My guess, <alloca.h> conditional is safe to drop.

autoconf has a macro for this, AC_FUNC_ALLOCA. See https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.66/html_node/Particular-Functions.html

cannam commented 4 years ago

Thanks for the patch and notes! I've chosen a related approach which is to expand the set of tests in sysutils.h, using only stdlib.h except where expressly indicated, and then remove the inclusions from the other files and replace them with explicit inclusions of sysutils.h.

I hope this works for you - let me know if there are further problems.