search

breakfastquay / rubberband

Official mirror of Rubber Band Library, an audio time-stretching and pitch-shifting library.
http://breakfastquay.com/rubberband/
GNU General Public License v2.0
580 stars 93 forks source link

LADSPA clicks/pops #20

Closed davidhealey closed 2 years ago

davidhealey commented 4 years ago

When using the LADSPA plugin in Audacity or Ardour (the hosts I've tried) Rubberband introduces pops and clicks at the start of the audio. This doesn't happen when using the CLI program with the same settings.

davidhealey commented 4 years ago

I think I might have solved the issue. I edited the ladspa code to increase the buffer and reserve values from 1024 to 2048 and so far it seems the clicks/pops issue is gone.

davidhealey commented 4 years ago

Btw I made a fork including this modification and I also merged FalkTX's LV2 addition.

https://github.com/davidhealey/rubberband

davidhealey commented 4 years ago

Well my fix was not a fix, I'm still experiencing issues when using rubberband as a plugin. I'm noticing it mainly with the cents parameter.

Example is attached rubberband artefacts.zip

cannam commented 2 years ago

Please give v2.0 (or the current repo default branch) a try if you haven't already - there were significant changes to the handling of real-time pitch changes in this release and a corresponding overhaul of the LADSPA plugin. (There's also now an LV2 plugin in the repo, though this wasn't in 2.0.)

davidhealey commented 2 years ago

Please give v2.0 (or the current repo default branch) a try if you haven't already - there were significant changes to the handling of real-time pitch changes in this release and a corresponding overhaul of the LADSPA plugin. (There's also now an LV2 plugin in the repo, though this wasn't in 2.0.)

Thanks, I'll give it a try!

davidhealey commented 2 years ago

Yes that seems much better, I didn't notice any pops/clicks :)