search

breakfastquay / rubberband

Official mirror of Rubber Band Library, an audio time-stretching and pitch-shifting library.
http://breakfastquay.com/rubberband/
GNU General Public License v2.0
580 stars 93 forks source link

Rubberband requiring fftw3 instead of fftw in craft #25

Closed 0101coding closed 3 years ago

0101coding commented 4 years ago

While installing kdenlive on macOS using craft, it pulls rubberband and it has fftw3 as a dependency in the configure file, but somehow what I have in craft is fftw

See screenshot

Screenshot 2020-02-18 at 16 53 13
cannam commented 3 years ago

I'm afraid I don't know what craft is, but this looks like just a naming issue. On other platforms the pkg-config file for fftw is called fftw3.pc, while here it appears to be called fftw.pc. Copying it to fftw3.pc might work, but this is probably an issue for the packagers.

The next Rubber Band release will have a different build system, and I'll be sure to make it check for both names - once upon a time this would have been dangerous (it might have picked up the incompatible fftw2) but I think those days are long past.

cannam commented 3 years ago

Predictably enough, having said I would be sure to check both names, I quite forgot to make that change before releasing v1.9.1! Doh.

However - I have also remembered that on the Mac we don't actually need fftw, since the system vDSP library suffices. And the new build system will take care of that, without failing if fftw is not found. So I think we should have got away with it, regardless of my idiocy.