search

breakfastquay / rubberband

Official mirror of Rubber Band Library, an audio time-stretching and pitch-shifting library.
http://breakfastquay.com/rubberband/
GNU General Public License v2.0
566 stars 91 forks source link

replace LADSPA plugin with LV2 #34

Closed Be-ing closed 2 years ago

Be-ing commented 3 years ago

@falkTX has made a Rubberband LV2 plugin. It would be nice to merge this upstream. This could allow removing the legacy LADSPA plugin.

cannam commented 2 years ago

I have added an LV2 plugin. It's not the same as Filipe's, but his repo did make for useful documentation.

I didn't see a lot of point in doing this before Rubber Band v2.0, because the plugin wasn't very well-behaved previously - it is a lot more reliable now because of the timing work done for v2.0.

Even so, I'm afraid this doesn't technically fix the issue here, because the issue calls for replacing the LADSPA plugin, and I haven't done that and I don't intend to do so yet at least. That's simply because I still routinely use LADSPA hosts that don't support LV2 - indeed I develop one. The two formats are built from the same implementation at least.

Be-ing commented 2 years ago

Cool, thanks!

this doesn't technically fix the issue here

:shrug: It doesn't hurt to keep the LADSPA plugin.