breakfastquay / rubberband

Official mirror of Rubber Band Library, an audio time-stretching and pitch-shifting library.
http://breakfastquay.com/rubberband/
GNU General Public License v2.0
561 stars 89 forks source link

Fix broken common/Allocators.h include for JNI #64

Closed dvzrv closed 1 year ago

dvzrv commented 2 years ago

src/jni/RubberBandStretcherJNI.cpp: Set the include for common/Allocators.h correctly so that JNI can be built successfully.

dvzrv commented 1 year ago

@cannam seems you fixed this in https://github.com/breakfastquay/rubberband/commit/020702e7eaf36eb39de1e68f4b838c82a1291291 so I'll close.

cannam commented 1 year ago

Oh! How embarrassing, I hadn't even seen this PR, I'm sorry. I don't always look very closely at PRs because I can't actually pull them (this being only a mirror of the Mercurial repository). I only fixed the problem after someone else opened a bug report for it (see #69). I need to pay more attention.

dvzrv commented 1 year ago

Ah, it's alright as long as it gets fixed in the end :) It was a trivial fix (to get it to build) FWIW.