search

breakfastquay / rubberband

Official mirror of Rubber Band Library, an audio time-stretching and pitch-shifting library.
http://breakfastquay.com/rubberband/
GNU General Public License v2.0
561 stars 89 forks source link

Fix build type detection in meson.build #88

Closed triallax closed 3 months ago

triallax commented 1 year ago

The original detection code mistakenly detects the build type as "Debug" when the buildtype is plain, even though plain actually disables debugging (see https://mesonbuild.com/Builtin-options.html#details-for-buildtype). It's better to instead check the debug option directly.

cannam commented 3 months ago

Belated thanks for this PR - I've pushed a change based on it. (I can't actually merge Github PRs because the Github repo is only a mirror for the source repo, which is still a Mercurial one.)

triallax commented 3 months ago

thanks, i had forgotten this exists at all