BlueAgent
commented
3 years ago Oh geez, seems like this is going to be an interesting one to fix.
Plonk uses a heuristic to determine if it should be rendered as a normal item or as a block but it's far from perfect. The way vanilla item frames work is that each item has an associated camera transform for rendering in an item frame. Since it's not feasible to have each item (vanilla and potentially modded) to have a camera transform for plonk, a heuristic is needed to detect what renders "like a block" and then plonk applies a transformation before using the item frame rendering.
After going through the vanilla items list, seems like conduits, beds, banners and shields render strangely. (Although the banner one is kinda neat, maybe there should be a way to manually select the render type for such situations that the heuristic fails or for cosmetic reasons...)
So banners stick out a bit and so do dragon heads. Not too sure how to address these without more special casing, but this should be okay for now.
I'm thinking of adding the ability to flip between render types for cosmetic purposes as the banners before this fix were kinda neat.
For now though I'm gonna consider this fixed for the next release, will close once it's out.
Let me know if you got some ideas.
Shields are not properly displayed (1.12 although It might be on any version)