search

breakintoprogram / agon-mos

Official AGON QUARK Firmware: eZ80 MOS
MIT License
74 stars 16 forks source link

make SET KEYBOARD= case insensitive and eliminate parameter check in MOS. #59

Open lennart-benschop opened 1 year ago

lennart-benschop commented 1 year ago

The MOS SET command does a case sensitive compare of its parameter KEYBOARD. While the MOS commeand names themselves and file names are case-insensitive, the KEYBOARD parameter is case-sensitive.

It also does a compare of the value. More keyboard layouts could be added to the VDP code (plus underlying vpd-gl) and the VDU handler already checks the parameter. It's not a good idea that you have to change the check in MOS, each time you extend the range of supported keyboards in VDP.

leighbb commented 1 year ago

As part of #60, I have added strcasecmp(). This would enable this enhancement to be easily done.

breakintoprogram commented 12 months ago

@lennart-benschop I will keep the check in MOS as it is useful to report back to the user when an invalid set is selected, and is no big deal to update. Will fix the case sensitivity.