Change request for the Linux client code.
src\client\linux\handler\minidump_descriptor.h
src\client\linux\handler\minidump_descriptor.cc
1. Please add a CrashContext parameter to MinidumpCallback. It's very usefull
for handling the dump files without having to parse them.
How it's now:
typedef bool (*MinidumpCallback)(const MinidumpDescriptor& descriptor,
void* context,
bool succeeded);
How it should be:
typedef bool (*MinidumpCallback)(const MinidumpDescriptor& descriptor,
void* context,
bool succeeded,
const CrashContext* crash_context);
2. In HandlerCallback:
typedef bool (*HandlerCallback)(const void* crash_context,
size_t crash_context_size,
void* context);
The only type which is passed as the crash_context parameter is CrashContext.
Maybe the type of the parameter should be changed to "const CrashContext*"
instead of "const void*".
The attached files implement these two small changes.
Labels:
Linux client ExceptionHandler MinidumpCallback HandlerCallback CrashContext
Original issue reported on code.google.com by ronfr...@gmail.com on 14 Jan 2014 at 2:41
Original issue reported on code.google.com by
ronfr...@gmail.com
on 14 Jan 2014 at 2:41Attachments: