search

breamware / sidekiq-batch

Sidekiq Batch Jobs Implementation
MIT License
357 stars 95 forks source link

rescue nil swallowing exceptions #13

Closed midhunkrishna closed 7 years ago

midhunkrishna commented 7 years ago

https://github.com/breamware/sidekiq-batch/blob/master/lib/sidekiq/batch/callback.rb#L12 swallows all exceptions.

Ideally, this shouldn't be rescued, there by giving feedback to the developer

infinite-monkeys commented 7 years ago

We ran into this too. It was confusing as to why things failed.

nglx commented 7 years ago

Released 0.1.4 with it (https://rubygems.org/gems/sidekiq-batch/versions/0.1.4) so closing.