search

breamware / sidekiq-batch

Sidekiq Batch Jobs Implementation
MIT License
357 stars 95 forks source link

Update Integration Tests #25

Closed jbrady42 closed 5 years ago

jbrady42 commented 5 years ago

The integration tests have been modified to use fakeredis and sidekiq testing mode. This means the tests can now be run non interactively. Basic rspec expectations have been added to test cleanup of redis keys as well as presence of callbacks in the output. Currently only integration.rb functions as intended. This test simply adds to the current batch in the perform method.

A few new tests have been added to exercise more complex workflows. These tests are not passing as this functionality is broken at the moment. I have a PR on the way that will correct this.

simple.rb test a nested batch with no registered callbacks nested.rb tests deep nesting with callbacks workflow.rb a complex workflow with nesting and sequential batches

This should help better describe the current functionality and verify new fixes.

nglx commented 5 years ago

This is pretty impressive. Thanks @jbrady42