search

breamware / sidekiq-batch

Sidekiq Batch Jobs Implementation
MIT License
357 stars 95 forks source link

fix issue #32 - send success after failed jobs successfully end #37

Closed Wolfer closed 4 years ago

nglx commented 4 years ago

@Wolfer could you elaborate a bit on the fix, so I could merge it?

Wolfer commented 4 years ago

it was a long time ago, I may be mistaken in the details =)

The problem was that success-callback did not run after the job ended correctly after failed try. Success-callback run only job correctly ended at first time. If the job is taken from the RetrySet, then success-callback will never be called.

nglx commented 4 years ago

Thank @Wolfer let me merge it and test it a bit before a release.