breamware / sidekiq-batch

Sidekiq Batch Jobs Implementation
MIT License
357 stars 95 forks source link

Use yielded block for pipeline arguments #52

Closed ekampp closed 2 years ago

ekampp commented 2 years ago

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0

redis.multi do
  redis.get("key")
end

should be replaced by

redis.multi do |pipeline|
  pipeline.get("key")
end

This also prevents shadowing the r variable inside the block.

nglx commented 2 years ago

Hey @ekampp could you rebase to the latest master to see if tests are passing in gh actions? https://github.com/breamware/sidekiq-batch/pull/55

nglx commented 2 years ago

🙇 thank you @ekampp