Update for Sidekiq 7 - Githubissues

breamware / sidekiq-batch

Sidekiq Batch Jobs Implementation

MIT License

357 stars 95 forks source link

Closed martijnbolhuis closed 7 months ago

martijnbolhuis commented 7 months ago

I took the changes from https://github.com/breamware/sidekiq-batch/pull/88 and fixed the tests. Please have a look if these changes make sense.

Use string version of true in redis. The redis-client gem does not support booleans 1.
Replace fakeredis gem with an actual Redis in github actions because fakeredis is not compatible with Sidekiq 7 and the redis-client gem 2.
Remove unsupported Ruby version from Github actions CI.

nglx commented 7 months ago

Thank you @martijnbolhuis & @gammons, merging it to master - please let me know if it works I'll then bump the version and release.

gammons commented 7 months ago

@nglx can you do a gem release with this PR in it? Thank you!