search

brebory / thinkful-fewd-best-practices

Repository for Thinkful's FEWD Mentors to compile information about front end best practices.
MIT License
3 stars 3 forks source link

DRY up the classes #10

Closed jescalan closed 10 years ago

jescalan commented 10 years ago

Closes #5

brebory commented 10 years ago

I was so eager to get you involved I merged this one without taking a look. While I agree that some of the classes may not be necessarily required, I'm of the opinion that you should use a class on every element that needs styling. It provides a more meaningful name for each ui element, which aids in understanding and maintainability. Still, this one is open for discussion. Also, when I merged #8, I undid this pull request, so you won't see these changes in master anymore.

SORRY! Like I said, we can discuss this more in depth.

jescalan commented 10 years ago

Hah, no worries. But yeah I definitely don't agree, the whole css language (cascading stylesheets) is built around the fact that you don't have to do this, and you can use descendant selectors for styling rather than littering your html with a bunch of extra classes. But maybe we can open up another thread for this and see what other people think.