search

brechtsanders / xlsxio

XLSX I/O - C library for reading and writing .xlsx files
MIT License
417 stars 112 forks source link

Update CMakeLists.txt #71

Closed Pospelove closed 4 years ago

brechtsanders commented 4 years ago

Thanks for the pull request. Can you tell me what exactly this fixes? Did your run into a scenario where the existing defines weren't sufficient (like for example xlsxio_write_SHARED_EXPORTS as defined by ADD_LIBRARY(xlsxio_write_SHARED SHARED ...))?

Pospelove commented 4 years ago

@brechtsanders Hello. I tried to pass ON on to the BUILD_SHARED option and found out that DLLs are built but do not export anything.

Pospelove commented 4 years ago

I am working on adding your library into vcpkg: https://github.com/microsoft/vcpkg/pull/11994. Btw, https://github.com/brechtsanders/xlsxio/pull/64 is also a problem. For now, I fix it on vcpkg side.