search

breck7 / scrollsdk

The code for Particles and Parsers, which Scroll is built on.
https://sdk.scroll.pub
383 stars 17 forks source link

Parsers: instead of highlight scope, should it be themeColor? #186

Closed breck7 closed 2 months ago

breck7 commented 3 months ago

Highlight scope doesnt really map so great.

What about having something like: themeColor? and it could be a number 1 - N (say 1 - 20), and we provide some color palettes (maybe 2: light and dark), and they are stratified appropraitely, so you can just assign a number to a cell type, and it will have a good color.

breck7 commented 3 months ago

When we fix this can also fix this related to blob parser color highlighting: https://github.com/breck7/pldb/commit/c149a62bbbf8cbffb537d41624ed325a93ab1597#r144785623

breck7 commented 2 months ago

Renamed highlightScope to paint.

Closing the rest for now.