search

bredelings / BAli-Phy

Bayesian co-estimation of phylogenies and multiple alignments via MCMC
http://www.bali-phy.org/
GNU General Public License v2.0
45 stars 16 forks source link

workflow: update dependencies #8

Closed jonchang closed 4 years ago

jonchang commented 4 years ago

Testing for workflow.

jonchang commented 4 years ago

Vendored boost fails on macOS building in c++17 mode with clang.

jonchang commented 4 years ago

simple typo here: should be export PATH=$HOME/bin:$PATH - but you knew that

also this is fun. I have never used this commenting tool before

You can also make suggestions inline!

jonchang commented 4 years ago

For doing ninja -j4, my impression is that ninja auto-discovers how many processes it should run. This could still maybe speed things up, if the virtual machine is configured to look like it has only one core.

Yeah this is the case. The documentation says "2 cores only" but from the grapevine they say that the machines are actually far more powerful than they advertise.

jonchang commented 4 years ago

Squashed and rebased given the boost changes.

bredelings commented 4 years ago

BTW, I'm not really sure what's happening with boost. Debian and ubuntu packages don't have these weird -mt-x64 suffixes on the end. I think that madness is mostly inspired by Windows systems, which have e.g. different versions of the libraries (!) if its a debug build or not.

It looks like maybe it was finding some non-system version of boost, but only during compilation. Then, when attempting to actually RUN the programs, it could only find the system version.

jonchang commented 4 years ago

It looks like maybe it was finding some non-system version of boost, but only during compilation. Then, when attempting to actually RUN the programs, it could only find the system version.

Yup, GHA runners installs some voodoo version of boost which was causing trouble: https://github.com/actions/virtual-environments/blob/master/images/linux/scripts/installers/boost.sh

bredelings commented 4 years ago

That's gross. rm -rf indeed!

jonchang commented 4 years ago

I feel like this is the last stage of the war with CI.

Next step is to set up a release pipeline and get it to work on Windows!

jonchang commented 4 years ago

This is ready to merge. Feel free to git rm .travis.yml whenever 👋

bredelings commented 4 years ago

Thanks Jon, that is awesome! I am away from wifi until tomorrow morning but will happily remove Travis then.