bredzhang / shellinabox

Automatically exported from code.google.com/p/shellinabox
0 stars 0 forks source link

/etc/default/shellinabox does not allow overriding parameters i.e. "-c" and daemon does not log #11

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

1. Install using generated .deb file
2. Edit /etc/default/shellinabox giving custom "-c" (or -g) option.
3. Startup fails with "Only one certificate directory can be selected" etc.

Note, also, no messages of any kind are logged to syslog or daemon.log - it
was necessary to manually turn off "quiet" options and even then the error
came to stdout, not to a log file.  Expected behaviour with a .deb
installed daemon would be for log messages to go to /var/log files, and for
*something* to be logged in the case of a startup failure.

Original issue reported on code.google.com by TomOeh...@gmail.com on 30 Mar 2009 at 1:40

GoogleCodeExporter commented 8 years ago
Probably the easy fix would be to put all the parameters in 
/etc/default/shellinabox
instead of hard-coding any in the start-stop-daemon command in
/etc/init.d/shellinabox.  I'm not sure how the /var/log behaviour is supposed 
to be
controlled by the init.d, but I'm pretty sure directing to stdout or stderr and 
then
being silent on failure is suboptimal.

Original comment by TomOeh...@gmail.com on 30 Mar 2009 at 1:43

GoogleCodeExporter commented 8 years ago
I changed the code to allow overriding of some of the other parameters. I also 
made 
sure that fatal error messages always get printed to stderr, even when running 
in 
quiet mode.

Please let me know, if you need additional changes made.

Original comment by zod...@gmail.com on 30 Mar 2009 at 5:07