breedx2 / futel-usage-viz

Some graphs showing usage data
0 stars 0 forks source link

add other items #39

Closed breedx2 closed 3 years ago

breedx2 commented 3 years ago

resolves #38

@kra note the comment in the issue about missing outgoing_detroit_menu (which I went ahead and added here) and the name outgoing-ivr being weird with incoming-ivr in the mix.

kra commented 3 years ago

LGTM. The naming inconsistency is an implementation artifact.

kra commented 3 years ago

Oh, as you note, incoming-ivr probably shouldn't be in there, it depends on what we want to show. With incoming-ivr, it's "initial menus". Without, it's "initial menus when user picks up futel phone".

We can leave it out, whatever.

breedx2 commented 3 years ago

Just going to merge for now. Other items can be added/removed with a future follow-up PR.