Closed climba03003 closed 2 years ago
Merging #131 (beaa61d) into master (769c6bd) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #131 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 397 395 -2
=========================================
- Hits 397 395 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/index.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 769c6bd...beaa61d. Read the comment docs.
could you move removeSafeTimer inside of class and then bind it in the constructor like we have done with other functions. otherwise looks good to me!
could you move removeSafeTimer inside of class and then bind it in the constructor like we have done with other functions. otherwise looks good to me!
@shadowgate15 Updated.
Thank you @climba03003
Fixes #130
I do a refactor on code about removing the timers on bree. It is a duplicate of code in multiple places. If you do not like it, I can revert it.