feat: allow resiliency with accepted extensions

breejs / bree

Bree is a Node.js and JavaScript job task scheduler with worker threads, cron, Date, and human syntax. Built for @ladjs, @forwardemail, @spamscanner, @cabinjs.

https://jobscheduler.net

MIT License

3.04k stars 79 forks source link

feat: allow resiliency with accepted extensions #229

Closed mikevalstar closed 10 months ago

mikevalstar commented 12 months ago

Upgrade resiliency with file extensions on jobs

Currently if you specify a file extension that does not start with a . it will think a job like defaults is a typescript file.

Alternatively I can add a check similar to the default extension that already exists, but i thought this would be better?

Happy to have some feedback as needed.

Thanks for creating such a good tool

Checklist

[x] I have ensured my pull request is not behind the main or master branch of the original repository.
[x] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[x] I have written a commit message that passes commitlint linting.
[x] I have ensured that my code changes pass linting tests.
[x] I have ensured that my code changes pass unit tests.
[x] I have described my pull request and the reasons for code changes along with context if necessary.

socket-security[bot] commented 12 months ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@tsconfig/node20	20.1.2	None	`+0`	2.5 kB	typescript-deploys
@types/node	20.8.3	None	`+0`	3.92 MB	types

mikevalstar commented 12 months ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher @tsconfig/node20 20.1.2 None +0 2.5 kB typescript-deploys @types/node 20.8.3 None +0 3.92 MB types

Note: this is only for the example I added, no changes to the main library

titanism commented 10 months ago

apologies for delay, we've been working hard on https://forwardemail.net 🚀

v9.2.0 released to npm just now https://github.com/breejs/bree/releases/tag/v9.2.0

fyi - we did a minor bump since don't use nor support TypeScript (we dislike it with with a passion) but we tried to bump package type stuff around to make things work (tests were broken in ci). playing it safe by doing this as a minor bump.

thank you for your contributions @mikevalstar 🙏 🙇

p.s. check out our encrypted sqlite IMAP support just released in November.

titanism commented 10 months ago

had to deprecate v9.2.0 due to #232

please use v9.2.1+ instead

glad we did the minor bump.

https://github.com/breejs/bree/releases/tag/v9.2.1