Interval parsing issue

[ChrisEdgington]

Specifying a job interval of every 10 seconds as opposed to 10s results in the following very confusing error:

    this[kPort].postMessage({
                ^

DOMException [DataCloneError]: function(d) {
        return getInstances("next", 1, d, d) !== later.NEVER;
      } could not be cloned.
    at new Worker (internal/worker.js:200:17)
    at Bree.run (/Users/cedgington/repos/personal/temp/express-example/node_modules/bree/index.js:573:28)

You can see this by simply using the example project (as I did) and modify only the interval.

[niftylettuce]

Almost done with the fix

[ChrisEdgington]

LOL - I just was about to post - debugged it to a problem with how you're using later. Guess I'll wait ...

[niftylettuce]

v1.1.26 has been released to npm

try it out and it should work OK for you @ChrisEdgington - let me know otherwise

I published deprecation notice as well for all versions prior

[niftylettuce]

https://github.com/breejs/bree/releases/tag/v1.1.26

[ChrisEdgington]

The parsing and initial run now works - but then Bree exits, which is different behavior than the other syntax.

const taskman = new bree({ jobs: [ { name: 'Worker 1', path: worker_1, interval: 'every 5 seconds' }, { name: 'Worker 2', path: worker_2, interval: 'every 10 seconds' }, ] })

These jobs run once then Bree exits.

-Chris

On Aug 13, 2020, at 9:46 PM, niftylettuce notifications@github.com wrote:

v1.1.26 has been released to npm

try it out and it should work OK for you @ChrisEdgington https://github.com/ChrisEdgington - let me know otherwise

I published deprecation notice as well for all versions prior

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/breejs/bree/issues/23#issuecomment-673830762, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBR3ZK7GDPWKDKHWTNBZA3SASJRHANCNFSM4P67QKHQ.

[niftylettuce]

Can you share a reproducible test case or repository I can run?

[ChrisEdgington]

const Bree = require('bree');

const bree = new Bree({ jobs: [ { name: 'Exiter', path: worker, interval: 'every 10 seconds' } ] });

function worker() { console.log('I am working ...') }

bree.start();

On Aug 13, 2020, at 9:52 PM, niftylettuce notifications@github.com wrote:

Can you share a reproducible test case or repository I can run?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/breejs/bree/issues/23#issuecomment-673838222, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBR3ZLRQNHTH6WTG3O3NM3SASKF7ANCNFSM4P67QKHQ.

[niftylettuce]

looking into this, thanks

[niftylettuce]

I see what's wrong, it's a similar issue where it's not checking for isValid

[niftylettuce]

Got the fix, one sec

[niftylettuce]

The core bug all along with this whole issue was this line:

      const schedule = later.schedule(later.parse.text(value));
      if (schedule.isValid()) return schedule;

Instead of returning schedule, we needed to return later.parse.text(value) instead.

[niftylettuce]

v1.1.27 released, try it out and let me know if this works for you @ChrisEdgington

https://github.com/breejs/bree/releases/tag/v1.1.27

I also published deprecation notice for all versions prior.

[ChrisEdgington]

LOL - yes, I had already fixed the problem there - but I just changed it to return schedule.next(1). I was surprised by your initial fix and decided, “Wow, I must not understand what is going on."

On Aug 13, 2020, at 10:19 PM, niftylettuce notifications@github.com wrote:

The core bug all along with this whole issue was this line:

  const schedule = later.schedule(later.parse.text(value));
  if (schedule.isValid()) return schedule;

Instead of returning schedule, we needed to return later.parse.text(value) instead.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/breejs/bree/issues/23#issuecomment-673846413, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBR3ZKSFF525JD7Y76SZH3SASNKHANCNFSM4P67QKHQ.

[niftylettuce]

🤦 sorry hahahaha

[ChrisEdgington]

1.1.27 appears to be working properly - thanks for the fix.

On Aug 13, 2020, at 10:23 PM, niftylettuce notifications@github.com wrote:

🤦 sorry hahahaha

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/breejs/bree/issues/23#issuecomment-673847544, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBR3ZLCUNKK4BPJNJEIT7LSASN37ANCNFSM4P67QKHQ.

[niftylettuce]

Great to hear, thank you @ChrisEdgington for confirmation. If you need anything else or have questions let me know.