search

breejs / later

*Maintained fork of Later.* A javascript library for defining recurring schedules and calculating future (or past) occurrences for them. Includes support for using English phrases and Cron schedules. Works in Node and in the browser.
https://breejs.github.io/later/
MIT License
134 stars 13 forks source link

[bug] tests aren't 100% working #1

Closed niftylettuce closed 4 years ago

niftylettuce commented 4 years ago

It seems like there's a timezone offset issue with running the tests versus the original author's timezone (which are hardcoded). There might be other issues too, e.g. with the original codebase. I did notice one major issue which I thought stood out, search for "TODO" in the src/index.js file to see the comment.

jdalrymple commented 4 years ago

Does later take into consideration timezones? Or is it just set to the hardcoded ones like you mentioned above?

niftylettuce commented 4 years ago

It seems like this fork of later is the culprit behind the issues found in https://github.com/breejs/bree/issues/29.

niftylettuce commented 4 years ago

Something went wrong with my fork, I'm going to spend a little time here trying to figure it out... If you see anything let me know.

niftylettuce commented 4 years ago

I got it figured out, will release shortly.

niftylettuce commented 4 years ago

This is now resolved as of v4.0.0. I am also releasing a new version of bree now.