search

breejs / later

*Maintained fork of Later.* A javascript library for defining recurring schedules and calculating future (or past) occurrences for them. Includes support for using English phrases and Cron schedules. Works in Node and in the browser.
https://breejs.github.io/later/
MIT License
134 stars 13 forks source link

TypeScript declarations #4

Closed P4sca1 closed 3 years ago

P4sca1 commented 3 years ago

@niftylettuce Are you interested in hosting the typescript declarations in this repository or even convert this project to typescript? There already exist type declarations under @types/later which in case you don't want to copy them to this repository, would need to be published under @types/breejs__later by doing a pull request to DefinitelyTyped. For users it might be easier to ship the declarations directly with this package.

Also I just saw that you combined all the files into a single huge index.js file which IMO makes it harder to read the code. Could you clarify why this change was made?

Thanks for maintaining later! ❤️

niftylettuce commented 3 years ago

Hey thanks for filing this, unfortunately I don't support TypeScript on any of my projects. It's bad for open source and development in general. I combined them and fixed the tests. The code was already hard to read and had several bugs and I had limited time to do this so that was the best approach.

delewis13 commented 3 years ago

Curious as to why not leverage the work already done for @types/later?

Seems an easy fix for a relatively large win for any typescript users who want to use this library.

niftylettuce commented 3 years ago

Like I said I strictly don't support TypeScript. It's really bad for the open source JavaScript community.