Added a bunch of new endpoints, all of them linked to club activities

breeku / trackmania-api-node

npm module for Trackmania2020 API

https://trackmania-api-node.netlify.app/

MIT License

13 stars 3 forks source link

Added a bunch of new endpoints, all of them linked to club activities #31

Open Sigeth opened 3 years ago

Sigeth commented 3 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) New endpoints supported for the live services part
What is the current behavior? (You can also link to an open issue here) /
What is the new behavior (if this is a feature change)? Added : getClubCampaignById getClubRoomById getClubSkins getClubBucketById getClubById getClubActivitiesById Tests for all of these functions
Other information: Now it's better than the last time xD Hope it's all good !

Sigeth commented 3 years ago

Is there anything that I need to change ?

breeku commented 3 years ago

Is there anything that I need to change ?

Hey, sorry it's taking time to answer...

By quick glance it look's good! I will have to test the functions myself before we merge. I will try to get it done this week

Sigeth commented 3 years ago

If you want, I can change the .spec.ts file so you can gain some time, and just test it more easily, I just have to figure out how the format works And don't worry about the time :D

Sigeth commented 3 years ago

So I've done the tests, you can use it if it's good :D

Sigeth commented 3 years ago

🆙

Sigeth commented 3 years ago

🆙 🆙 🆙 😄