search

breenie / silex-doctrine-migrations-provider

A doctrine migrations provider for Silex and Pimple
MIT License
21 stars 11 forks source link

Add support for Doctrine Migrations 2.0 #21

Open jwage opened 6 years ago

jwage commented 6 years ago

I have been working on Doctrine Migrations 2.0 in https://github.com/doctrine/migrations master.

Opening an issue here to discuss and track progress for upgrading this library to 2.0.

hkdobrev commented 6 years ago

@jwage Thanks for bringing this up! Would you be interested in contributing support for Migrations 2.0?

Open/closed issues on the 2.0 milestone: https://github.com/doctrine/migrations/milestone/14?closed=1

Interesting addition is the ability to dump and rollup schema: https://github.com/doctrine/migrations/pull/689 This is something we've done with custom commands so far to load current schema in test environment.

I'd recommend not releasing a version which supports both Doctrine Migrations 1.0 and 2.0. I think the added overhead exceeds the benefits. We could just release a new major version of the provider.

So we'd need to adjust for the deprecated classes if we're using them, update to the new namespaces and add the 2 additional commands to the list.

breenie commented 6 years ago

@hkdobrev I was thinking exactly the same. Initially I thought it might by possible to support both in one version but quickly realised it wouldn't be possible to test properly.

Reading the upgrade docs the main changes are just naming. Making this edit is probably trivial but adding more functionality might be more involved unless of course it's just the addition of new commands, I haven't looked in any detail at what is available.

Edit: I just reread your comment and you seem to have said exactly what I did :)

hkdobrev commented 6 years ago

I couldn't find any new functionality which concern us other than 2 new commands. At first glance, the upgrade should be quite trivial.

breenie commented 6 years ago

Is there a release date for 2.0? I can't find any road map.

hkdobrev commented 6 years ago

I think they'd just release when ready. They've updated requirements for DBAL to 2.6, so I don't think they would be waiting to release together with Doctrine 3.0.

We could just create a 1.0 branch from current master and use master requiring 2.0 of the migrations with a branch alias. I don't think the provider would need much updates on the 1.0 so the default could be about 2.0 and when they release it, we'll just test with the latest tag and release as well :)

breenie commented 6 years ago

Sounds like a plan to me. I'm not too sure about using master in composer and would prefer to limit it to a version but suppose we could do this when we release.

jwage commented 6 years ago

I plan to release 2.0 in the next few weeks and the first alpha release will be this week.

hkdobrev commented 6 years ago

I've just re-read your first comment and realised you are the actual maintainer of the Doctrine migrations library! 😅

Kudos to going through the integration libraries to notify everyone! 👏

breenie commented 6 years ago

I've created an initial upgrade in the branch feature/doctrine-2. I'm totally used to git flow and am inept at creating a pull request (because basically I never do it). If anybody could give me some pointers on how to do this correctly I'd appreciate it. I will be switching to a more github flow for this project so please bear with me in the mean time.

hkdobrev commented 6 years ago

@breenie You could create a new pull request from here: https://github.com/kurlltd/silex-doctrine-migrations-provider/compare/master...feature/doctrine-2

When solely using GitHub flow and the default branch is master, GitHub would prompt you to create a PR after pushing a branch.

If you're a CLI fan, you'd love hub.

breenie commented 6 years ago

Thanks, created #22.