breese / trial.protocol

Network wire protocols
11 stars 4 forks source link

Add json::partial::skip(reader&) #30

Closed vinipsmaker closed 6 years ago

vinipsmaker commented 6 years ago

Closes #23

vinipsmaker commented 6 years ago

I have resolved all review comments in a separate commit. Please let me know when you're finished, so I can squash them in a single commit (it makes git history more beautiful).

vinipsmaker commented 6 years ago

@breese: okay, new commit resolving new comments added. As before, please let me know when you're done so I can squash all commits into one.

breese commented 6 years ago

Looks good

vinipsmaker commented 6 years ago

Okay: squashed to one commit. Also added one more test, test_one_object (but there were no changes to the implementation or any other part).