search

breez / breez-sdk-greenlight

MIT License
244 stars 43 forks source link

Add `matches_callback_domain` flag to LNURL URL success action #1039

Closed dangeross closed 4 months ago

dangeross commented 4 months ago

This PR removes the validation of the success action URL to match the LNURL callback domain and instead sets matches_callback_domain on UrlSuccessActionData if there is a mismatch.

Fixes #1028

ok300 commented 4 months ago

Is the goal to remove the domain matching check?

If so, matches_callback_domain should be propagated to SuccessActionProcessed, which is what's returned by lnurl_pay. Otherwise the caller has no way of telling the domains matched or didn't match.