breez / breez-sdk-greenlight

MIT License
241 stars 42 forks source link

Makefile should build for the _current_ target by default #403

Open JssDWt opened 1 year ago

JssDWt commented 1 year ago

When using the makefile, most commands should use the current target by default. If a developer wants to compile the python bindings, he should call make python for example, and it should work for the target he is on currently.

In order to get the current target, we could use TARGET=$(rustc -vV | sed -n 's|host: ||p'). (not sure whether that works on all platforms). There should be logic for copying the correct binaries to the correct locations. It could be .dylib, .so, .dll for example.

So

dangeross commented 1 year ago

The command produces x86_64-apple-darwin on mac 👍

ok300 commented 1 year ago

x86_64-unknown-linux-gnu on linux