breez / breez-sdk-greenlight

MIT License
244 stars 43 forks source link

Update bindings-kotlin-multiplatform to use version catalog #997

Closed angelix closed 5 months ago

angelix commented 5 months ago

Update dependencies

atomicfu = "0.24.0"
android-gradle-plugin = "8.4.1"
jna = "5.14.0"
kotlin = "1.9.24"
kotlinx-datetime = "0.6.0"
okio = "3.9.0"
roeierez commented 5 months ago

Thanks @angelix does it fix any issue you experienced or it is only about updating the dependencies?

angelix commented 5 months ago

Thanks @angelix does it fix any issue you experienced or it is only about updating the dependencies?

Updating dependencies and better organize them. I have plans to support Kotlin 2.0.0 & also desktop targets, but this will require a help from you to build the required binaries.

roeierez commented 5 months ago

@dangeross can you review this please?

angelix commented 5 months ago

LGTM, it also brings the JNI version inline with the android bindings.

@angelix were you able to test locally, or shall we create a pre-release build so you can test?

@dangeross haven't test it, a pre-release would be great.