search

breez / breezmobile

Lightning Network mobile client
https://breez.technology
GNU General Public License v3.0
567 stars 130 forks source link

Wrong message for pending closed channel #1278

Closed Nackoo2000 closed 3 months ago

Nackoo2000 commented 4 months ago

The numbers are wrong in the dialog message and the $ sign has to be removed. 321561885-2eb2f429-cb93-43df-93a9-4de930f86dd5

Nackoo2000 commented 3 months ago

I am not sure if this was solved so I can test for it.

erdemyerebasmaz commented 3 months ago

@Nackoo2000 It's not solved and was not part of this release but I'll take a look.

erdemyerebasmaz commented 3 months ago

@Nackoo2000 The numbers aren't wrong per se, but your account's tip height appears to be 0 when this dialog was opened.

(blockheight - account's tipHeight) 10 (In theory there is one block per 10 minutes) / 60 which gives us (793830 - 0)10/60 = 132305 hours

Could you try recreating this with latest build and share logs? We'll investigate why account response returned tip height as 0.

I'll be removing the $ signs.

Nackoo2000 commented 3 months ago

When I reported this it was an old node that was in this state it was not during testing. Not sure how exactly to recreate this case please give me a step-by-step.

erdemyerebasmaz commented 3 months ago

When I reported this it was an old node that was in this state it was not during testing. Not sure how exactly to recreate this case please give me a step-by-step.

You can use the cooperative close channels feature, the pending close transaction should appear on tx list

Nackoo2000 commented 3 months ago

The whole section is skipped so I think this is good and we can close the issue - your call. image

erdemyerebasmaz commented 3 months ago

The whole section is skipped so I think this is good and we can close the issue - your call.

The message does not appear if the estimation is below an hour.

we can close the issue - your call.

The $'s are removed and there isn't anything wrong with the estimation calculations. I will be closing the issue.

We need to understand why your account's tipHeight was 0 at the time you opened this dialog, please reopen the issue if you encounter it again.

Nackoo2000 commented 3 months ago

Now I remember that this was not my issue but it came from a support case but I will be on the lookout for it.