search

breez / breezmobile

Lightning Network mobile client
https://breez.technology
GNU General Public License v3.0
568 stars 130 forks source link

missing UI for failed swap #1306

Open MarnixCroes opened 1 month ago

MarnixCroes commented 1 month ago

General Description

There is no user feedback in the case that a swap fails.

How To Reproduce?

  1. Go to Receive
  2. Click on Receive via BTC address
  3. swap fails
  4. there is no way for the user to know that it failed, he assumes he got rugpulled as balance doesn't get updated

only after 288 blocks user sees the option for refund and knows that the swap failed

Breez Version

0.17

kingonly commented 1 month ago

That's not accurate. It depends on the reason of the failure. If the swap is under or over the limit, there's an indication in a form of a warning icon. If we keep trying to swap, we don't show an error because there's a chance the swap will succeed. Do you know what caused your swap to fail?

MarnixCroes commented 1 month ago

That's not accurate. It depends on the reason of the failure. If the swap is under or over the limit, there's an indication in a form of a warning icon. If we keep trying to swap, we don't show an error because there's a chance the swap will succeed. Do you know what caused your swap to fail?

ok. @JssDWt figured it out: the max possible receive amount for not opening a new channel doesn't take into account the extra commitment fee for a htlc. (a bug that is/was going to be fixed) please correct me if I'm wrong.

JssDWt commented 1 month ago

@JssDWt figured it out: the max possible receive amount for not opening a new channel doesn't take into account the extra commitment fee for a htlc. (a bug that is/was going to be fixed)\nplease correct me if I'm wrong.

Correct