breez / breezmobile

Lightning Network mobile client
https://breez.technology
GNU General Public License v3.0
573 stars 131 forks source link

Replace keysend with AMP #743

Closed Kixunil closed 2 years ago

Kixunil commented 2 years ago

According to LND doc, keysend shouldn't be used anymore and AMP should be preferred.

Using keysend only puts people into awkward situation when they have to enable a deprecated option.

kingonly commented 2 years ago

What exactly you want us to replace? Are you referring to podcasting? Because that's not our specification.

Not sure AMP is going to last either, it's probably going to be replaced by bolt12. In this case it's better to go with something that is supported by all lightning implementations (e.g. keysend) or even better part of the protocol standard (bolt12 hopefully?).

kingonly commented 2 years ago

Btw, when keysend came up in the roundtable with LL, roasbeef stated it's not going to be deprecated soon (even once AMP is enabled). So this also requires some clarification.

Kixunil commented 2 years ago

Are you referring to podcasting?

Yes, sorry for being unclear.

Because that's not our specification.

Where can I raise this issue then?

it's probably going to be replaced by bolt12

Good point!

roasbeef stated it's not going to be deprecated soon

OK, I wanted to avoid supporting keysend just to remove it later but looks like I can't.

kingonly commented 2 years ago

Value block specification is here: https://github.com/Podcastindex-org/podcast-namespace/blob/main/value/value.md#value-element

Dave and Adam (podcasting 2.0 leaders) are well aware of the alternatives and waiting to see where the chips falls.

Btw, I also DMed you on telegram on this.