breezetall / pe

0 stars 0 forks source link

Edit or sort changes the index of the contact #3

Open breezetall opened 5 months ago

breezetall commented 5 months ago

For sorting it may not be an issue as list displays all tasks however, edit changes a specific index. If the contact changes index, it becomes inconvenient for the user to see their edited contact.

Steps to reproduce: 1) sort ca1 2) list

or 1) edit 1 [!any param]

Calling the list command after edit does not affect the list either.

Before:

image.png

After:

image.png

nus-se-bot commented 5 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for the observation. However, this is an intended behaviour of the programme. When a user wishes to edit any specific person, they do so by referring to the index shown in the current list displayed in the student panel and entering that index in their edit command (as shown in the UG for edit). A person is not tied to any specific index and a user would thus never memorise an index of a contact in order to edit it. They would instead reference the index shown in the student panel. Therefore, sorting changing the index does not impact the user, amd thus we feel that this issue does not inconvenience the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]