Add location from a map

papjul commented 1 year ago

Describe your suggested feature

Add ability to choose a specific position from a map.

That would allow user than don't want to share their location or have localisation turned on at all time, to put a specific point on the map, especially for big cities.

There is already an hidden FAB button on location list that we can use.

See if osmdroid project can help us for map library.

Other details

Replace the search page with a new page like Google Maps:

A search bar at the top
A map with osmdroid lib
Searching for a city with the search put all results on the map (so you can see cities with the same name and pick the correct one), and on a bottom sheet where all results are listed and you can just tap an "Add" button

IMG_20231111_061925

Can be done at a later point:

Pinpoint to put add your own specific longitude, latitude, instead of the location search result with the center of a city (can be done later)

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to latest version.

papjul commented 7 months ago

Needs a reverse geocoding source first

Rafee-M commented 2 months ago

Having the map option would be definitely useful, but the map library would have to be an optional download to keep it lightweight.

The latitude and longitude input would be more functional and efficient I believe while keeping the map optional

papjul commented 2 months ago

Sorry, we have no plans to make an additional flavor to save 861.71 KB of dependency.

Your suggestion is not more efficient or user-friendly because you have to use an additional tool to get your longitude and latitude, compared to just tapping on the map where you want to add. And it's not more functional, it's the opposite: it lacks many of the functionalities listed in the first post.

Additionally, what you suggest already kinda exists: if you type lat,lon in the AccuWeather search, you will get the closest result for this point.

Rafee-M commented 2 months ago

Sorry, we have no plans to make an additional flavor to save 861.71 KB of dependency.

I didn't mean a separate flavour. And it was my bad, I assumed the map would be locally stored.

Additionally, what you suggest already kinda exists: if you type lat,lon in the AccuWeather search, you will get the closest result for this point.

Ah didn't know that, thanks!

breezy-weather / breezy-weather