breezy-weather / breezy-weather

A Material Design Weather Application
GNU Lesser General Public License v3.0
5.41k stars 165 forks source link

Part of marker remains visible on Precipitation Nowcasting #1001

Open 2013ZRZ opened 5 months ago

2013ZRZ commented 5 months ago

Steps to reproduce

1.See Precipitation Nowcasting 2.Click on the chart

Expected behavior

Nothing is left when you loosen it.

Actual behavior

There's a line.

Weather source used

AccuWeather

Breezy Weather version

5.2.1 armeabi_v7a

Android version

EMUI 5.1.3 Android Nougat

Device

Honor 6a

Other details

No response

Acknowledgements

2013ZRZ commented 5 months ago

IMG_20240422_201236

github-actions[bot] commented 5 months ago

It looks like the version in which you encounter the issue is not the latest version of Breezy Weather. The latest version contains potential fixes and troubleshooting improvements, so we kindly ask you to update first. If you are getting updates from the F-Droid default repo, you don’t need to uninstall your currently installed version. If you can still reproduce your issue after updating, please comment on this issue.

2013ZRZ commented 5 months ago

I'm sorry. The version information in that comment is incorrect. I'm inputted incorrectly. Now I'm changed it.

papjul commented 5 months ago

Alright, can you see a marker when you hold tap on the chart?

2013ZRZ commented 5 months ago

Yes. When the bubble passes by, a light line will appear. When the lines overlap, the colors of the lines become darker (see Screenshot).

papjul commented 5 months ago

Could you download the sample APK from the chart library we use here: https://github.com/patrykandpatrick/vico/releases/tag/v2.0.0-alpha.16

And let us know if you can reproduce the same issue in any of the examples with a marker available?

2013ZRZ commented 5 months ago

No, I can't. But I didn't use dark mode, so it's possible that I can't see the marker because the color left is the same as the background color.

papjul commented 5 months ago

No, I can't.

You answer to "Can you reproduce", right?

I can't see the marker

So, you can see a marker in Breezy Weather but not in any of the examples of the sample app?

2013ZRZ commented 5 months ago

No, I can't.

You answer to "Can you reproduce", right?

I can't see the marker

So, you can see a marker in Breezy Weather but not in any of the examples of the sample app?

Yes.

Has chart of vico what breezy weather used a bubble? My Android version didn't support dark mode. For the reasons I mentioned earlier, I can't see the bubble.

papjul commented 5 months ago

What does the marker have to do with the dark mode?

2013ZRZ commented 5 months ago

In vico, I can't see the bubble. There are two possibilities:

  1. There is no bubble.
  2. If I use the dark mode, the background color isn't white, so I can see the bubble. But in light mode, the background color is white. That I can't see the bubble. However, the possible premise is that the color of the bubble is white and will not change with the theme.

I may not have made it clear in the previous comments. I mean that there are bubbles in the chart data in Breezy Weather, but there are no bubbles in similar charts in the vico sample application (maybe because I can't see them, as mentioned in the previous paragraph).

2013ZRZ commented 5 months ago

In vico, I can't see the bubble. There are two possibilities:

  1. There is no bubble.
  2. If I use the dark mode, the background color isn't white, so I can see the bubble. But in light mode, the background color is white. That I can't see the bubble. However, the possible premise is that the color of the bubble is white and will not change with the theme.

I may not have made it clear in the previous comments. I mean that there are bubbles in the chart data in Breezy Weather, but there are no bubbles in similar charts in the vico sample application (maybe because I can't see them, as mentioned in the previous paragraph).

Because the line of Precipitation Nowcasting in Breezy Weather is the same color as the bubble, I think there is such a line in vico. I just can't see it because the color is close to or the same as the background color.

papjul commented 5 months ago

Could you take a screenshot of:

Thanks!

papjul commented 5 months ago

Additional question: can you reproduce in v5.2.3 of Breezy Weatger? I just installed it on an Android 5.0 phone, which is an even older version than yours, and I don't have this issue, with or without dark mode

2013ZRZ commented 4 months ago

Could you take a screenshot of:

  • The marker in Breezy Weather
  • The marker in "Chart 2" (or whatever is shown when you tap on the chart)

Thanks!

https://github.com/breezy-weather/breezy-weather/assets/130883435/034d01d2-b697-4b95-8386-7c29388c11d3

https://github.com/breezy-weather/breezy-weather/assets/130883435/7a3b80da-50bf-4512-a235-5f5243e082bf

Additional question: can you reproduce in v5.2.3 of Breezy Weatger? I just installed it on an Android 5.0 phone, which is an even older version than yours, and I don't have this issue, with or without dark mode

The problem still appears, as in the previous version.

papjul commented 4 months ago

I notice on your second video that you don't have any background in the marker, just the text. That's a different issue, but this time, this is something I can reproduce on my 13-years old phone.

I’m sorry, but I’m out of ideas. I don’t know if that’s an EMUI, a faulty hardware driver, or something wrongly handled on the lib side. I will leave this open to other contributors if they have an idea, but it’s mostly a cosmetic issue so it should not prevent the general usage of the app.

papjul commented 2 months ago

Still happening in v5.2.6?

2013ZRZ commented 2 months ago

Still happening in v5.2.6?

Yes.

I just tested it on three other devices, and one of them can reproduce this problem. I found that the screen aspect ratio of two mobile phones that can reproduce the problem is 16:9, while the normal screen aspect ratios of the two mobile phones are 13:6 and 21:9. So I think this problem may be related to the aspect ratio of the screen.

papjul commented 2 months ago

16:9 is a common ratio; can't reproduce on my 16:9.

What are those two devices so I can check if I see anything else in common?

2013ZRZ commented 2 months ago

What are those two devices so I can check if I see anything else in common?

The following are two devices that can reproduce this problem and some of their parameters:

HUAWEI nova youth

Honor 6A