search

breezy-weather / breezy-weather

A Material Design Weather Application
GNU Lesser General Public License v3.0
5.32k stars 161 forks source link

Add a night background for splash screen #137

Open papjul opened 1 year ago

papjul commented 1 year ago

Describe your suggested feature

Currently the app opens with a blue sky in background, however this can be a bit too bright when requesting a dark mode environment.

I suggest adding a "night" background by default (same color as clear night animation), then switch to current blue sky if user prefers the light theme.

The reason is due to this bug: https://stackoverflow.com/questions/63187994/how-to-place-the-splash-screen-for-dark-and-light-mode-in-android

In that case, it’s best to have a dark theme first to not have a bright splash screen that then switch to a darker splash screen.

Other details

No response

Acknowledgements

Atn-D commented 1 year ago

Can you propose a non-living background, uni color material you?

papjul commented 1 year ago

Splash screen isn't animated, it's just an unicolor background with the logo on top of it.

ludles commented 6 months ago

Is this still planned? 👀

Would it be a good idea to simply change the colour #5F96D0 in the following to #191B1D? (or some other colour with a soft/darker hue) https://github.com/breezy-weather/breezy-weather/blob/e2f5892322462c20fbbd45c7f7a4058b3c03ae61/app/src/main/res/values/ic_launcher_background.xml#L3

This is not a perfect solution, but brightly coloured splash screens cause more discomfort for dark theme users than vice versa.

papjul commented 6 months ago

This issue has not been planned yet.

The implementation is the one described in first post.

ludles commented 6 months ago

The implementation is the one described in first post.

Yes, I saw that, and I do agree that it is a good implementation. Here, I am only suggesting that before this is implemented properly as described (especially without any specific plan), perhaps simply changing the colour can be a temporary improvement?

I can make a PR if needed.

shaft17 commented 6 months ago

Would it be a good idea to simply change the colour #5F96D0 in the following to #191B1D? (or some other colour with a soft/darker hue)

I agree, this would be a quick temporary solution. But I also do understand that the "branding" of Breezy is the light blue...

Korb commented 5 months ago

the "branding" of Breezy is the light blue...

I’m quite happy if the application is launched by tapping on the blue icon. But if I'm using a device with an AMOLED screen, and prefer to minimize battery consumption, and prefer comfort when using the smartphone in the dark, I prefer to have #000 as the background, and use the system brightness settings to control the brightness of text and graphics, and only their.

papjul commented 5 months ago

I'm using a device with an AMOLED screen, and prefer to minimize battery consumption

Pure black does not save more battery than gray on multiple hours of test: https://www.xda-developers.com/amoled-black-vs-gray-dark-mode/

I think we can extrapolate the same results with blue on a 500 ms splashscreen.

and prefer comfort when using the smartphone in the dark, I prefer to have #000 as the background, and use the system brightness settings to control the brightness of text and graphics, and only their.

The splashscreen is very brief, compared to -let’s say- the weather background on main screen of the app.

For the app, please have a look at #147. However, it’s only to replace the gray background. If you want a pure black and white app and you're a developer, we support WeatherSpec from Gadgetbridge that allows you to re-use Breezy Weather data on your own app. We are also working on our own spec that will make more data available.