breezy-weather / breezy-weather

A Material Design Weather Application
GNU Lesser General Public License v3.0
5.34k stars 162 forks source link

[Minor UI Issue] Daily Forecast Interface Offset #761

Closed FlysonBot closed 6 months ago

FlysonBot commented 6 months ago

Steps to reproduce

Open Breezy Weather, scroll down to Daily Forecast.

Expected behavior

The "reading windows" (explained below) should overlap with today's weather.

Actual behavior

Screenshot_20240307-190536 markup_1000000858

In the picture, we can see the weather of each day and a "reading window" (the rectangle that looks a little bit lighter, highlighted in the second image, I don't know how you'll call that thing). I observed that the "reading window" will shift to the right as you scroll to the right, and you can find yesterday's weather when you scroll to the left. However, a problem is that the reading window is now not overlapping with today's weather, it sit between today and tomorrow, because when you hide yesterday's whether by default you technically scrolled to the right which caused the reading window to also shift to the right.

Weather source used

AccuWeather

Breezy Weather version

5.0.3-alpha

Android version

Android 14

Device

Pixel 4A

Other details

No response

Acknowledgements

papjul commented 6 months ago

when you hide yesterday's whether by default you technically scrolled to the right which caused the reading window to also shift to the right.

It just works like a scrollbar:

When there is no yesterday and first day is today, the reading window is on far left on top of today.

When there is yesterday and you are on today (the 2nd day), the reading window is more or less on the right (depends on the length of the forecast), since you scrolled a bit to the right.

Just like a scrollbar.

Not sure if there is an issue I missed?

FlysonBot commented 6 months ago

You understand the mechanism correctly. The issue is, the yesterday's weather is displayed but not shown by default, which caused the reading window to shift to the right by default. However, the app automatically scroll in a way such that the reading window doesn't overlap with the today's weather by default. That means whenever you open the app, the reading window will never sit right on top of today's weather. Not a major issue to me, but some people who just want perfect UI would be like why is this not aligned perfectly by default.

FlysonBot commented 6 months ago

Unless that reading window is not supposed to help with reading but to tell you where you at in the scroll bar. Which case is this?

papjul commented 6 months ago

the reading window will never sit right on top of today's weather. Not a major issue to me, but some people who just want perfect UI would be like why is this not aligned perfectly by default.

It's a scrollbar. If you go to the end of the forecast, you will see that the "reading window" doesn't stay on top of today, but follows the horizontal “list” and never stay on today.

Since you have yesterday before today, the scrollbar is already moved slightly to the right. Only the first and last item can be aligned (on the left or on the right). The scrollbar doesn't align with today but with the first or last element. If the first element is today, then it will be aligned with today. If the first element is yesterday, then it will be aligned with yesterday. It would not serve the purpose of showing the scroll progress if it was aligned on the left with the second element.

The issue is, the yesterday's weather is displayed but not shown by default

We automatically scroll to “today” element. I can remove that behavior and make the daily chart start on yesterday so that you will have your reading window aligned on top of yesterday, but I'm pretty sure most people prefer to see more of the future forecast than yesterday (by default).

FlysonBot commented 6 months ago

I see what you mean. I didn't thought it was a scrollbar. I was thinking of it as a highlight of the current reading position.